Fix ORC writer OOM issue #7605
Merged
Fix ORC writer OOM issue #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
vuule
requested review from
trxcllnt,
jrhemstad,
rgsl888prabhu,
kaatish and
devavret
and removed request for
trxcllnt and
jrhemstad
rgsl888prabhu
approved these changes
Mar 16, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7605 +/- ##
===============================================
+ Coverage 81.86% 82.39% +0.52%
===============================================
Files 101 101
Lines 16884 17350 +466
===============================================
+ Hits 13822 14295 +473
+ Misses 3062 3055 -7
Continue to review full report at Codecov.
|
|
rerun tests |
kaatish
approved these changes
Mar 16, 2021
devavret
approved these changes
Mar 16, 2021
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7588
The stream size used to be calculated incorrectly, leading to huge allocation for the encoded data buffer.
This PR fixes the stream size computation to count each row group only once.